Comments on: jsTree v.0.8.1 http://vakata.com/en/archives/20 Sometimes I sit and wonder... and sometimes I just sit Wed, 17 Dec 2008 08:19:09 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Arman http://vakata.com/en/archives/20/comment-page-1#comment-239 Arman Mon, 17 Nov 2008 15:24:43 +0000 http://vakata.com/en/?p=20#comment-239 Thank you Vakata for your time, and the tree! The code corks but always returns #. It looks like it's being replaced? I would like to be able to set and get a link for some of the nodes. What is the best way to accomplish this? thank you. Thank you Vakata for your time, and the tree!

The code corks but always returns #. It looks like it’s being replaced?

I would like to be able to set and get a link for some of the nodes. What is the best way to accomplish this?

thank you.

]]> By: vakata http://vakata.com/en/archives/20/comment-page-1#comment-238 vakata Mon, 17 Nov 2008 10:04:56 +0000 http://vakata.com/en/?p=20#comment-238 @Arman You should do: <code> $(NODE)<strong>.children("a")</strong>.attr("href"); </code> @Arman
You should do:

$(NODE).children("a").attr("href");

]]> By: Arman http://vakata.com/en/archives/20/comment-page-1#comment-237 Arman Mon, 17 Nov 2008 02:52:32 +0000 http://vakata.com/en/?p=20#comment-237 I'm tring to get the callback to return the href. I'm using an xml_flat type and the menu works but it always returns undefined.. <code> callback : {   onchange : function(NODE) {     alert("click:" + $(NODE).attr("href"));   } } </code> thank you I’m tring to get the callback to return the href. I’m using an xml_flat type and the menu works but it always returns undefined..

callback : {
  onchange : function(NODE) {
    alert("click:" + $(NODE).attr("href"));
  }
}

thank you

]]> By: nomen http://vakata.com/en/archives/20/comment-page-1#comment-216 nomen Mon, 03 Nov 2008 12:32:07 +0000 http://vakata.com/en/?p=20#comment-216 Hi all: In onrename function I´m using the values of NODE.firstChild.textContent to get the new name of the node and send it by ajax to my server. It works great for Chrome and Firefox. But, in IE it gives me "undefined" value. What i´m doing bad? Is there a better way to get the new name of the node? I´m using 0.8.1. version. Thank you very much in advance. Hi all:

In onrename function I´m using the values of NODE.firstChild.textContent to get the new name of the node and send it by ajax to my server.
It works great for Chrome and Firefox. But, in IE it gives me “undefined” value.
What i´m doing bad? Is there a better way to get the new name of the node?
I´m using 0.8.1. version.
Thank you very much in advance.

]]> By: bogdan http://vakata.com/en/archives/20/comment-page-1#comment-212 bogdan Wed, 29 Oct 2008 15:14:29 +0000 http://vakata.com/en/?p=20#comment-212 forgot the main think to get all root nodes if(!nod || $(nod).size() == 0) nod = this.container.find("ul:eq(0) > li"); forgot the main think to get all root nodes
if(!nod || $(nod).size() == 0) nod = this.container.find(“ul:eq(0) > li”);

]]> By: bogdan http://vakata.com/en/archives/20/comment-page-1#comment-211 bogdan Wed, 29 Oct 2008 14:58:09 +0000 http://vakata.com/en/?p=20#comment-211 I see another problem with getJSON. If I have multiple root items it doesn't export all of them, just the first one. To fix that, I've enclosed all the code into a var arr; nod.each(function() { .... arr.push(obj); } return arr; I see another problem with getJSON. If I have multiple root items it doesn’t export all of them, just the first one.
To fix that, I’ve enclosed all the code into a
var arr;
nod.each(function() {
….
arr.push(obj);
}
return arr;

]]> By: bogdan http://vakata.com/en/archives/20/comment-page-1#comment-209 bogdan Sun, 26 Oct 2008 16:56:22 +0000 http://vakata.com/en/?p=20#comment-209 I had to use elementFromPoint because on IE document.click gets called after container.mouseup on drag operations. When document.click got called, it turned focus of all instances off. On Firefox document.click doesn't get call and focus remained on the drop target. Since it's only needed on IE you could say ($.browser.msie && elementFromPoint). I had to use elementFromPoint because on IE document.click gets called after container.mouseup on drag operations. When document.click got called, it turned focus of all instances off. On Firefox document.click doesn’t get call and focus remained on the drop target.
Since it’s only needed on IE you could say ($.browser.msie && elementFromPoint).

]]> By: vakata http://vakata.com/en/archives/20/comment-page-1#comment-206 vakata Fri, 24 Oct 2008 07:50:45 +0000 http://vakata.com/en/?p=20#comment-206 @bogdan Thank you for all the submissions, please continue - this really helps developement! I commited just now - to summon the changes: * rename function ESC key is fixed (I decided not to populate the scope and just set "input.value = last_value" if ESC is pressed, and then only call the callback if "input.value != last_value") * CSS marker - I set z-index to 1000 in tree_component.js (I feel kind of odd traversing the DOM - I guess it would be better to set it to a really high value - as far as I know this does not affect performance) * copy - native copy impemented * get_json - I modified the function - the attributes you suggested were OK, but I decided to add an additional attrib parameter. So I set your values as defaults, but still the function accepts a list of attributes to include. * get_left, get_right - Thanks :) I really had not noticed the default behaviour - it is now fixed. What is left: * instance manager & focused instance - a really needed improvement, I will use what you gave me and try to improve. I am just worried about elementFromPoint not working in Firefox < 3. So let's see what else we can use! * states (hover, active, focus) - I'll do a research of what is best :) @bogdan
Thank you for all the submissions, please continue – this really helps developement!

I commited just now – to summon the changes:
* rename function ESC key is fixed (I decided not to populate the scope and just set “input.value = last_value” if ESC is pressed, and then only call the callback if “input.value != last_value”)
* CSS marker – I set z-index to 1000 in tree_component.js (I feel kind of odd traversing the DOM – I guess it would be better to set it to a really high value – as far as I know this does not affect performance)
* copy – native copy impemented
* get_json – I modified the function – the attributes you suggested were OK, but I decided to add an additional attrib parameter. So I set your values as defaults, but still the function accepts a list of attributes to include.
* get_left, get_right – Thanks :) I really had not noticed the default behaviour – it is now fixed.

What is left:
* instance manager & focused instance – a really needed improvement, I will use what you gave me and try to improve. I am just worried about elementFromPoint not working in Firefox < 3. So let’s see what else we can use!
* states (hover, active, focus) – I’ll do a research of what is best :)

]]> By: bogdan http://vakata.com/en/archives/20/comment-page-1#comment-205 bogdan Fri, 24 Oct 2008 04:16:23 +0000 http://vakata.com/en/?p=20#comment-205 Notes for serving the entire jsTree thorugh AJAX (in my particular case, jsTree resides in an ASP UpdatePanel): 1. call constructors and handlers only once. I've used something like: if (!document.myTab) { document.myTab = new tree_component(); jQuery(document).bind('keydown', ............ } 2. call init methods each time the tree reloads through AJAX This way, jsTree objects remain in memory and they manage their own viewstate. One issue though, some internal bindings could be set twice in init function. If this is the case, it would be nice if the tree checks if handlers are already set before setting new ones. Notes for serving the entire jsTree thorugh AJAX (in my particular case, jsTree resides in an ASP UpdatePanel):

1. call constructors and handlers only once. I’ve used something like:
if (!document.myTab) {
document.myTab = new tree_component();
jQuery(document).bind(‘keydown’, …………
}

2. call init methods each time the tree reloads through AJAX

This way, jsTree objects remain in memory and they manage their own viewstate. One issue though, some internal bindings could be set twice in init function. If this is the case, it would be nice if the tree checks if handlers are already set before setting new ones.

]]> By: bogdan http://vakata.com/en/archives/20/comment-page-1#comment-204 bogdan Fri, 24 Oct 2008 03:44:01 +0000 http://vakata.com/en/?p=20#comment-204 Also, I see is a conflict between the mouse hovering and the keyboard navigation. When I move the mouse over the tree my keyboard navigation gets reset to the clicked node. I think it's a good idea to differentiate between active items (that are clicked), selected items (that change whenever keyboard navigation occurs) and hovered items (that only react to the mouse). Also, I see is a conflict between the mouse hovering and the keyboard navigation. When I move the mouse over the tree my keyboard navigation gets reset to the clicked node.

I think it’s a good idea to differentiate between active items (that are clicked), selected items (that change whenever keyboard navigation occurs) and hovered items (that only react to the mouse).

]]>